devspace icon indicating copy to clipboard operation
devspace copied to clipboard

feat(localRegistry): expose pod resources

Open Milias opened this issue 7 months ago • 6 comments

What issue type does this pull request address? (keep at least one, remove the others) /kind enhancement

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible) No issue.

Please provide a short message that should be published in the DevSpace release notes Exposed in the localRegistry configuration resources and annotations of the created Pods.

What else do we need to know? I am not very familiar with go or this codebase, if you have any suggestions please feel free!

Milias avatar May 26 '25 19:05 Milias

Deploy Preview for devspace-docs ready!

Built without sensitive environment variables

Name Link
Latest commit 06fa82681acc00009798816dcc5cc35481702177
Latest deploy log https://app.netlify.com/projects/devspace-docs/deploys/6870c36914c1310008dd8683
Deploy Preview https://deploy-preview-2964--devspace-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar May 26 '25 19:05 netlify[bot]

Before we review, would you mind looking at the errors from the failed check for Lint?

https://github.com/devspace-sh/devspace/actions/runs/15261087358/job/43202271440?pr=2964

deniseschannon avatar May 30 '25 19:05 deniseschannon

Before we review, would you mind looking at the errors from the failed check for Lint?

https://github.com/devspace-sh/devspace/actions/runs/15261087358/job/43202271440?pr=2964

Thanks for the heads up!

I removed those two unused fields, I had to guess a bit because I couldn't easily run the linter locally.

Hopefully that was all :)

Milias avatar May 30 '25 22:05 Milias

Hello!

I don't know exactly why there is a failing test, doesn't seem related to changes in the PR.

Is there something I could do?

Milias avatar Jun 05 '25 07:06 Milias

Hello!

I don't know exactly why there is a failing test, doesn't seem related to changes in the PR.

Is there something I could do?

It looks like this was a temporary failure. Could you also rebase your branch against main and push those changes? That will re-run the actions and hopefully they will work this time. fwiw, there's usually a button in GH to re-run, but I don't have that available right now.

lizardruss avatar Jul 10 '25 20:07 lizardruss

Done!

Let's see if pipelines collaborate :)

Milias avatar Jul 11 '25 07:07 Milias