devspace icon indicating copy to clipboard operation
devspace copied to clipboard

fix: KUBECONFIG gets set when using --kubeconfig via var DEVSPACE_FLAGS

Open siredmar opened this issue 1 year ago • 4 comments

What issue type does this pull request address? (keep at least one, remove the others) /kind bugfix

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible) resolves #2859

Please provide a short message that should be published in the DevSpace release notes Environment variable KUBECONFIG gets set when using --kubeconfig via variable DEVSPACE_FLAGS within devspace.yaml

What else do we need to know?

siredmar avatar May 29 '24 08:05 siredmar

Deploy Preview for devspace-docs canceled.

Built without sensitive environment variables

Name Link
Latest commit d8978ac70bef8e6ff4971b9c7828ad4e2f9e556a
Latest deploy log https://app.netlify.com/sites/devspace-docs/deploys/66eadf184d58890007fa84d1

netlify[bot] avatar May 29 '24 08:05 netlify[bot]

@FabianKramm, @LukasGentele would any of you guys mind reviewing this?

siredmar avatar Jun 03 '24 10:06 siredmar

@siredmar Can you take a look at the e2e test failures?

lizardruss avatar Jul 09 '24 15:07 lizardruss

@lizardruss

TL;DR Would you mind re-running the pipeline?

The failing e2e test seems like a problem with the OCI registry. Not sure if this is actually related to my change as both e2e tests for k8s 1.27.3 and 1.28.0 fail with the same error in different test cases both at exactly the same time (18:21:11). https://github.com/devspace-sh/devspace/actions/runs/9282659759/job/26246098358?pr=2860#step:8:5178 https://github.com/devspace-sh/devspace/actions/runs/9282659759/job/26246097543?pr=2860#step:8:3116

siredmar avatar Jul 10 '24 05:07 siredmar

@lizardruss please trigger a re-run of the e2e tests. Thanks.

siredmar avatar Sep 18 '24 13:09 siredmar

Unsure why linting suddenly fails, but I can address those in a separate PR.

lizardruss avatar Sep 18 '24 15:09 lizardruss