resolve require section from imports
What issue type does this pull request address? (keep at least one, remove the others) /kind bugfix
What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
This PR adds a special handling of the require section in loader.ResolveImports. Instead of overwriting command and plugin constraints, it appends them to the existing ones. This was not handled correctly before, as imported "libraries" overwrote the existing constraints.
It also changes the handling of constraints for devspace versios by adding the version constraints form imported files to a already existing constraint, separated by comma.
Example: >=6.0, >=6.1
Please provide a short message that should be published in the DevSpace release notes Fixed an issue where DevSpace did not resolve command and plugin constraints from imports
What else do we need to know?
Deploy Preview for devspace-docs canceled.
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | 0f6eb41406cc885da2aff5bd9a2b51c68b5aa81c |
| Latest deploy log | https://app.netlify.com/sites/devspace-docs/deploys/643958c8fe9038000866e760 |
Hi @dtomasi
Thanks a lot for the PR! Can I ask to add an e2e test for this? So we're sure we don't have regressions in the future