devspace icon indicating copy to clipboard operation
devspace copied to clipboard

feat: add SkipPushKindControlPlane option in image configuration

Open alexissellier opened this issue 2 years ago • 6 comments

What issue type does this pull request address? (keep at least one, remove the others) /kind feature

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible) Add an option called skipPushOnKindControlPlane on to only target worker node when pushing docker images using kind binary

Please provide a short message that should be published in the DevSpace release notes Add an option to prevent images to be push on kind control plane node,

alexissellier avatar Jan 26 '23 14:01 alexissellier

Hey @alexissellier, thanks for the PR! Seems like the e2e tests are failing, would you mind taking a look?

FabianKramm avatar Jan 30 '23 08:01 FabianKramm

@FabianKramm I am checking but could not reproduce on my local machine. I saw a warning "Cannot retrieve lastest version of UI" could it be related ?

alexissellier avatar Feb 06 '23 17:02 alexissellier

@alexissellier this seems like a very specific use case, I'm not sure if we should add another global pipeline flag just for that as we already have way too many flags. Isn't there another way how we could achieve this without any flag?

FabianKramm avatar Feb 09 '23 09:02 FabianKramm

@FabianKramm I can only add a configuration parameter if it suits you

alexissellier avatar Feb 09 '23 10:02 alexissellier

Deploy request for devspace-docs pending review.

Visit the deploys page to approve it

Name Link
Latest commit a0598bd56a78cfbae0adfabc64e2d04e0509c18a

netlify[bot] avatar Feb 14 '23 18:02 netlify[bot]

@FabianKramm I've removed all reference to a flag and only keep a config option

alexissellier avatar Feb 14 '23 18:02 alexissellier