devspace icon indicating copy to clipboard operation
devspace copied to clipboard

Backward compatibility issue - hooks for named sync from v1beta11 don't work with devspace v6

Open matskiv opened this issue 3 years ago • 1 comments

What happened? When using devspace v6 with a v1beta11 configuration some sync hooks are not executed.

What did you expect to happen instead? I expected my hook to be executed after a named sync is finished.

How can we reproduce the bug? (as minimally and precisely as possible) Add a named sync and a hook from the example below to a devspace.yaml that uses version: v1beta1 and run devspace dev. The is the relevant part of my devspace.yaml:

version: v1beta1
# ...
dev:
  sync:
    - name: ok
      imageSelector: ${IMAGE}

hooks:
- events: ["after:initialSync:ok"]
  command: "echo TEST - OK"

Local Environment:

  • DevSpace Version: 6.1.1
  • Operating System: linux
  • ARCH of the OS: AMD64 Kubernetes Cluster:
  • Cloud Provider: minikube
  • Kubernetes Version: Client "v1.24.2"

Anything else we need to know? This works as expected with devspace v5

/kind bug

matskiv avatar Oct 13 '22 09:10 matskiv

@matskiv I was not able to reproduce this using the following devspace.yaml and DevSpace 6.1.1. Can you try to reproduce again and see if it's still an issue?

version: v1beta11

vars:
  - name: IMAGE
    value: my-docker-username/helloworld

images:
  app:
    image: ${IMAGE}

deployments:
  - name: app
    helm:
      values:
        containers:
          - image: ${IMAGE}

dev:
  sync:
    - name: ok
      imageSelector: ${IMAGE}
      localSubPath: .
      containerPath: /app

hooks:
- events: ["after:initialSync:ok"]
  command: "echo TEST - OK"

lizardruss avatar Nov 09 '22 16:11 lizardruss