Mateusz Kielan

Results 368 comments of Mateusz Kielan

probably a good idea to fix as part of #143

See new comments on your PR, esp: https://github.com/Devsh-Graphics-Programming/Nabla-Examples-and-Tests/pull/8/files#r940222261

> ## Description > With our current event handling design we need an instance of the event handler in order to get the events, the default one worked well until...

> Solution 1 is the only one I'll accept. I misread the original description, what I meant is.. If you want the handler to do something else define a custom...

A couple of issues. # Fix my sphagetti code The pattern of having to remember to call `IGPUCommandPool::something` from the override of `something` in the base class, is incredibly dumb,...

# Review of the Interfaces ## Bug Using `std::forward` more than once: https://github.com/Devsh-Graphics-Programming/Nabla/pull/345#discussion_r863819861 Command segment won't really be 128k: https://github.com/Devsh-Graphics-Programming/Nabla/pull/345#discussion_r863768889 ## Design Failure There's a inversion of control going on,...

> > Therefore IGPUCommandBuffer::emplace and possibly even the deleteCommandSegmentList (as a function taking a head segment parameter) should move to IGPUCommandPool. > > For these: > > ```c++ > m_cmdpool->m_commandSegmentPool.allocate(IGPUCommandPool::COMMAND_SEGMENT_SIZE,...

> ## OpenGL Command Buffer Baking > ### What is happening now > * `SOpenGLContextLocalCache` is cached in the command buffer's `COpenGL_Queue`'s thread internal state (`ThreadInternalStateType`). > * The cached...

> Using these params we can create core::smart_refctd_dynamic_array for every descriptor type and store it in the IDescriptorPool instance. IGPUDescriptorSet would then, store pointers (or offsets) into these dynamic arrays....