Paradise-Lost icon indicating copy to clipboard operation
Paradise-Lost copied to clipboard

Various mechanics should be delegated to external api

Open SollyW opened this issue 3 years ago • 8 comments

Various mechanics are implemented in ways that are either a maintainance burden, duplicate effort, or cause imcompatibilities with other mods. These should be changed to use external apis; however, many of these apis currently do not exist. Feel free to add additional items to the list. Items marked with (*) already have an api in fapi or elsewhere

  • [x] *Enchantment tables with skyroot bookshelves (particle effect, enchantment level increase) (in third-party mod)
  • [ ] Skyroot buckets (fluids, milking)
  • [x] Aether farmland (moisture, rabbits, villagers, plantable, etc.)
  • [x] *Block colours
  • [x] *Item colours
  • [x] Glass pane and torch registering
  • [x] Entity model layers
  • [x] Falling leaf particles
  • [ ] *Quicksand gamerule network packets (maybe change gamerule to config value?)
  • [x] Item rarity
  • [x] *Fuel times for aether items
  • [x] *Strippable blocks
  • [x] *Shovels flattening aether grass
  • [x] Aether blocks added to ~~isSoil and~~ isStone checks in feature generation
  • [x] *Item groups
  • [ ] Simplex noise

SollyW avatar Jul 25 '21 02:07 SollyW

Damn you didn't need to murder CDA like that hmmmm

Azzyypaaras avatar Jul 25 '21 02:07 Azzyypaaras

Well some of these are really bad - the enchantment table and rabbit, for example, will cause a crash if another mods adds their blocks

SollyW avatar Jul 25 '21 02:07 SollyW

I believe gudenau has an API for the enchantment table and farmland, among other things we'd desire.

Jack-Papel avatar Jul 25 '21 08:07 Jack-Papel

Bookshelves and Aether Farmland ✔️

Jack-Papel avatar Aug 20 '21 05:08 Jack-Papel

Fuel, Pane, Torch, Particle ✔️

Jack-Papel avatar Aug 30 '21 07:08 Jack-Papel

Color Provs, Item Groups ✔️

Jack-Papel avatar Aug 30 '21 08:08 Jack-Papel

Only three to go ✔️

Jack-Papel avatar Sep 05 '21 04:09 Jack-Papel

Do we think this is sufficiently complete?

Jack-Papel avatar Mar 29 '22 17:03 Jack-Papel