Paradise-Lost icon indicating copy to clipboard operation
Paradise-Lost copied to clipboard

Published 20 hours ago • verified publisher icon devs-immortal

CloudRendererMixin contains a big chunk of copypasted code

Open SollyW opened this issue 3 years ago • 3 comments

CloudRendererMixin::internalCloudRender copies a large chunk of code from WorldRenderer::renderClouds. For maintainability and copyright reasons this should be avoided

SollyW avatar Jul 21 '21 09:07 SollyW

Agree with this, though to do so would need a major refactoring. I would be open to a PR having a more maintainable system however.

CDAGaming avatar Jul 21 '21 11:07 CDAGaming

Slated for PL b1.7

CDAGaming avatar Feb 05 '22 19:02 CDAGaming

Pushing this back- I'm not smart enough to refactor this but we make very small changes that would still require replacing the code with a mixin because of the data that we modify. Tried some workarounds but ended up infinitely looping because we mixin directly to the render clouds method and then would need to call it ourselves to not duplicate code

MBatt1 avatar Apr 27 '24 16:04 MBatt1