react-use-intercom icon indicating copy to clipboard operation
react-use-intercom copied to clipboard

Published 20 hours ago • verified publisher icon devrnt

Follow up: window.intercomSettings

Open devrnt opened this issue 2 years ago • 1 comments

It seems like window.intercomSettings isn't used in SPAs, according to https://github.com/devrnt/react-use-intercom/pull/481#issuecomment-1148940938. This is confirmed by someone from Intercom. We should follow this up and check for updated documentation, so we can remove the use window.intercomSettings uses in this codebase

devrnt avatar Jun 27 '22 16:06 devrnt

Also note that in both boot and update the "old" window.intercomSettings are spread into the new window.intercomSettings. So by removing the use of these global settings, we should introduce our own global settings reference

devrnt avatar Jun 27 '22 17:06 devrnt