Dev Random

Results 102 comments of Dev Random
trafficstars

should we run the xtest PoC only in one of the build variants, to reduce build time? or even make it a separate check? ~~I think it adds about 10...

validated with VLS in https://gitlab.com/lightning-signer/validating-lightning-signer/-/merge_requests/731 and https://gitlab.com/lightning-signer/validating-lightning-signer/-/merge_requests/733

> > I am making delegate optional for non-dev builds. is this what you wanted, or did you also want it to be optional for dev? > > Ugh, sorry...

cool, didn't realize `macro_rules` had that flexibility

done and rebased. there was one instance that a fn had a body, but I just expanded it for now.

(used the UI to merge, but will rebase if/when everything else is done)

> LGTM, the commit messages could be cleaned up though to follow [our guidelines](https://chris.beams.io/posts/git-commit) done