devopshq
Python 3.14 compatibility
Hello, I encountered an error when trying to use this module with Python 3.14, and I tried to suggest the appropriate changes in this PR.
TypeError: PurePath.init() got an unexpected keyword argument 'auth'
Tests for py 3.14 failed :thinking:
It seems that many changes have been made to pathlib between Python 3.13 and 3.14 (https://github.com/python/cpython/commit/f5ba74b81979b621e38be70ec3ddad1e7f1365ce), which seems to make the changes done in 32cdad0ffb2f9f27589baaf25988d09435921cd2 irrelevant with Python 3.14, especially these lines: https://github.com/devopshq/artifactory/blob/32cdad0ffb2f9f27589baaf25988d09435921cd2/artifactory.py#L1898-L1905 pathlib._abc.PathBase has been removed and kind of replaced by pathlib.types._ReadablePath, but I don't think _ReadablePath.glob() is a good replacement because it uses a hardcoded globber class _PathGlobber: https://github.com/python/cpython/blob/7cafd76a7fc6e52d93dd11e454a49c4dbebdf080/Lib/pathlib/types.py#L300-L314
The _globber attribute has been removed anyway in https://github.com/python/cpython/commit/f5ba74b81979b621e38be70ec3ddad1e7f1365ce, which makes the following lines also irrelevant with Python 3.14: https://github.com/devopshq/artifactory/blob/32cdad0ffb2f9f27589baaf25988d09435921cd2/artifactory.py#L1599-L1603
@allburov I'm not sure what's the best approach here, so maybe I'll leave this to you.
Hello, We are also using this package for our artifactory tasks and currently affected. Can you please update when this will be merged and release?
@Mrizwanshaik have you tested the PR for you case, does it work?
I'll leave this to you
It is a problem :laughing: I'm happy to review and merge PR but don't have much time to investigate the issue :cry:
@allburov
don't have much time to investigate the issue
Issue: Our bot is trying to bump python container to 3.14 in github workflow and we use the dohq-artifactory artifactory client package, which is currently not supported due to which validation is failing.
have you tested the PR for you case, does it work?
Yes I have tested the PR and it does work.