action-pull-request icon indicating copy to clipboard operation
action-pull-request copied to clipboard

passing a team for reviewer throws an error

Open EmiiFont opened this issue 3 years ago • 6 comments

:memo: Brief description

Hi, i'm trying to add the team as a reviewer but is not picking it up

I've tried reviewer: "team-prs" reviewer: "/team-prs" reviewer: "@org/team-prs" reviewer: "org/team-prs"

and it shows an error Error requesting reviewer: Unprocessable Entity (HTTP 422)

expected to pick up one of the members of the team to review

any ideas?

:warning: Checklist

  • [x] Provided a clear and concise description of what the issue is.
  • [ ] Given a clear and concise description of what is expected.
  • [ ] Proposed a clear and concise description of any alternative solutions or other features.
  • [ ] Added any other context or screenshots about the feature request.
  • [ ] Associated pull request has been already created and link was provided.

Check CONTRIBUTING.md and CODE_OF_CONDUCT.md for more information

EmiiFont avatar Aug 20 '21 22:08 EmiiFont

Hi! It appears to be a bug in hub binary. I checked it running directly via CLI and got the same errors:

Error creating pull request: Unprocessable Entity (HTTP 422)
You can't perform that action at this time.

I've created issue ticket for them to address the problem https://github.com/github/hub/issues/2825

Until it's fixed I can suggest different solution, which I'm always using - define CODEOWNERS file and then team would be automatically added based on the configuration.

ChristophShyper avatar Aug 25 '21 10:08 ChristophShyper

@ChristophShyper does it actually work with CODEOWNERS? It never assigns anything, even though github says file is correct.

oerp-odoo avatar Jun 07 '23 08:06 oerp-odoo

@oerp-odoo I'm using it for many years, even before actions. Do you have the default path * defined there?

ChristophShyper avatar Jun 07 '23 08:06 ChristophShyper

Oh, I thought you can have just user specified and it will work. Though I don't understand why github then shows file as valid. I would expect to see some info that its not valid. Thanks, I will try it.

oerp-odoo avatar Jun 07 '23 10:06 oerp-odoo

@ChristophShyper its working nicely, thanks. I can even use teams to auto assign from there randomly, which is nice.

oerp-odoo avatar Jun 07 '23 12:06 oerp-odoo

@oerp-odoo Great to hear

ChristophShyper avatar Jun 07 '23 16:06 ChristophShyper