glob-match

glob-match copied to clipboard

fix: 🚑 pattern with globstar and star fails to match

2

This aims to address some of the issues reported in #9. The cases reported there now work, although there are still scenarios not covered by this fix (but, well, they're...

lucas-labs

Pattern with globstar and star fails to match

3

```rust assert!(glob_match("**/*.js", "a/b.c/c.js")); ``` ``` assertion failed: glob_match(\"**/*.js\", \"a/b.c/c.js\") thread 'tests::abc' panicked at 'assertion failed: glob_match(\"**/*.js\", \"a/b.c/c.js\")' ``` `glob_match` returns `false` even though it should return `true`. This has something...

oleg-vinted

Hi, would you consider exposing an interface that works with &[u8]'s directly?

sleepybishop

If you have a glob that starts with a `**`, the behavior changes based on whether or not you wrap it in `{}`s. For instance: ```rust assert!(glob_match("**/*b", "ab")); assert!(glob_match("{**/*b}", "ab"));...

gsoltis

For libraries, it is common to not include the lockfile https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html#cargotoml-vs-cargolock https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries Perhaps we should consider following the convention.

arlyon

Unicode characters vs codepoints

1

Hi! It would be nice if this library specifies how it handles multi-codepoint-characters or graphemes (🎉 ). I was comparing this against the doublestar go library (https://github.com/bmatcuk/doublestar) which seems to...

arlyon

Possible Timing Issues on Untrusted Patterns

4

Hello, I saw this crate on Twitter and decided to fuzz it with a primitive algorithm: simply generate a random pattern and match it to the original input. After running...

sno2

Related to PR #15 Due to some reasons, I have to open a new PR. ## Benchmark ```rust const PATH: &'static str = "some/a/bigger/path/to/the/crazy/needle.txt"; const GLOB: &'static str = "some/**/needle.txt";...

shulaoda

fix: the logic of star backtracking

1

SyMind

```rust > glob_match("**/foo{bar,b*z}", "foobuzz") false ```

shulaoda