Devon Govett

Results 894 comments of Devon Govett

Unfortunately, the Vite plugin can only process one file at a time so `@custom-media` defined in a separate file cannot work. Vite would need to switch to using the Lightning...

Seems to work in the [playground](https://lightningcss.dev/playground/index.html#%7B%22minify%22%3Atrue%2C%22nesting%22%3Atrue%2C%22customMedia%22%3Atrue%2C%22cssModules%22%3Afalse%2C%22analyzeDependencies%22%3Afalse%2C%22targets%22%3A%7B%22chrome%22%3A6225920%7D%2C%22source%22%3A%22%40custom-media%20--screen-tablet%20(width%20%3E%3D%20860px)%3B%5Cn%5Cnbody%20%7B%5Cn%20%20background%3A%20blue%5Cn%7D%5Cn%5Cn%40media%20(--screen-tablet)%20%7B%5Cn%20%20body%20%7B%5Cn%20%20%20%20background%3A%20red%3B%5Cn%20%20%7D%5Cn%7D%22%2C%22visitorEnabled%22%3Afalse%2C%22visitor%22%3A%22%7B%5Cn%20%20Color(color)%20%7B%5Cn%20%20%20%20if%20(color.type%20%3D%3D%3D%20'rgb')%20%7B%5Cn%20%20%20%20%20%20color.g%20%3D%200%3B%5Cn%20%20%20%20%20%20return%20color%3B%5Cn%20%20%20%20%7D%5Cn%20%20%7D%5Cn%7D%22%2C%22unusedSymbols%22%3A%5B%5D%2C%22version%22%3A%22local%22%7D). Make sure that you are setting a `browserslist` though, or nothing will be compiled. Even though no browser supports`@custom-media` currently, we need to compile...

Ok thanks! So sounds like this is an implementation bug across all engines at the moment, with a fix coming in Firefox 139. I can report issues to V8 and...

Reported issues: Chromium: https://issues.chromium.org/issues/419464498 WebKit: https://bugs.webkit.org/show_bug.cgi?id=293431 Temporal Polyfill: https://github.com/js-temporal/temporal-polyfill/issues/341

Ah, thanks I missed that one.

hmm this looks like a different problem with ListLayout not including the persisted key...

@snowystinger added a commit to address it. Needed to clean up some old layout infos that should have been removed when we relayout from scratch (when Picker re-opens) so that...

I believe this one should be fixed also: https://github.com/orgs/adobe/projects/19/views/4?pane=issue&itemId=66042530 Specifically by these lines https://github.com/adobe/react-spectrum/pull/6527/commits/c7e714598a3ba3093990ec8b053fe06c063ee2f3#diff-2eb943b500782eb9da514ad98c5fb7855a412a495cb133e9a8e81cf656dff9f6R196-R197

One question: where did this requirement come from? Did you have an issue that was caused by using CommonJS? I think the tree shaking implementation should handle both the same...