ide icon indicating copy to clipboard operation
ide copied to clipboard

Setup handled as error if already installed and up-to-date

Open hohwille opened this issue 2 years ago • 4 comments

Installing lazydocker...
Rancher Desktop set as option
Rancher Desktop is already installed
Getting latest release...
error during connect: This error may indicate that the docker daemon is not running.: Get "http://%2F%2F.%2Fpipe%2Fdocker_engine/v1.24/version": open //./pipe/docker_engine: The system cannot find the file specified.
error during connect: This error may indicate that the docker daemon is not running.: Get "http://%2F%2F.%2Fpipe%2Fdocker_engine/v1.24/version": open //./pipe/docker_engine: The system cannot find the file specified.

Docker-Engine and Docker-API versions are sufficient
Version 0.20.0 of lazydocker is already installed.
Command 'lazydocker setup' failed with exit code 1
Failed to run devon lazydocker setup - do you want to continue?
(yes/no):

The setup of lazydocker did notice that already the desired version is installed. However, it did exit with code 1. I am confused why this happened: https://github.com/devonfw/ide/blob/249f5f680c86ca778bc5b97a21c23f93bffc8afa/scripts/src/main/resources/scripts/command/lazydocker#L36

I tested this with version 2022.11.001 that should have exactly the code above. Any ideas what I could be missing or where does the error code 1 come from?

hohwille avatar Nov 17 '22 08:11 hohwille

Side note:

Docker-Engine and Docker-API versions are sufficient

This is also incorrect as according to the 2 logged errors above he could not determine the docker versions so he actually does not know if the "versions are sufficient". However, if relevant this is another story or bug...

hohwille avatar Nov 17 '22 08:11 hohwille

Can also be reproduced separately:

$ devon lazydocker setup
Installing lazydocker...
Rancher Desktop set as option
Rancher Desktop is already installed
Getting latest release...
error during connect: This error may indicate that the docker daemon is not running.: Get "http://%2F%2F.%2Fpipe%2Fdocker_engine/v1.24/version": open //./pipe/docker_engine: The system cannot find the file specified.
error during connect: This error may indicate that the docker daemon is not running.: Get "http://%2F%2F.%2Fpipe%2Fdocker_engine/v1.24/version": open //./pipe/docker_engine: The system cannot find the file specified.

Docker-Engine and Docker-API versions are sufficient
Version 0.20.0 of lazydocker is already installed.

$ echo $?
1

hohwille avatar Nov 17 '22 08:11 hohwille

@CREITZ25 had the idea, that the version check command failed here so some exit 1 happened and this is not triggered from here: https://github.com/devonfw/ide/blob/249f5f680c86ca778bc5b97a21c23f93bffc8afa/scripts/src/main/resources/scripts/command/lazydocker#L36

hohwille avatar Dec 01 '22 14:12 hohwille

  1. I tested it with devon version 2022.12.001 , It returned with code 0 and it also shows the path where the lazydocker is installed.
$ devon lazydocker setup
Rancher Desktop set as option

Docker-Engine and Docker-API versions are sufficient
Version 0.20.0 of lazydocker is already installed at /c/Users/test/Project/devonfw-ide-scripts-2022.12.001.tar/software/lazydocker.
Version: 0.20.0
Date: 2022-11-12T04:29:12Z
BuildSource: binaryRelease
Commit: 530dbbe57009f4596bfeedba1c8169becd98b9a8
OS: windows
Arch: amd64
Success: verify installation of lazydocker (lazydocker)

  1. Docker-Engine and Docker-API versions are sufficient The installed Docker-Engine and Docker-API versions are verified by ensuring they are above the version specified in lazydocker github https://github.com/devonfw/ide/blob/70baf93ecffb8967f34be86c3ac6f4465b911af3/scripts/src/main/resources/scripts/command/lazydocker#L45-L47

error during connect: This error may indicate that the docker daemon is not running.: Get "http://%2F%2F.%2Fpipe%2Fdocker_engine/v1.24/version": open //./pipe/docker_engine: The system cannot find the file specified.
error during connect: This error may indicate that the docker daemon is not running.: Get "http://%2F%2F.%2Fpipe%2Fdocker_engine/v1.24/version": open //./pipe/docker_engine: The system cannot find the file specified.

The above error has occurred due to Dockerd. To fix it, open "Rancher Desktop", go to File>Preferences>Container Engine>General and select "Dockerd". Then devon lazydocker can be activated without any error.

Image

Ttring avatar Dec 28 '22 18:12 Ttring