cobigen
cobigen copied to clipboard
devonfw
Code-based Incremental Generator
Can be removed is already defined in the supertype commandCommons _Originally posted by @EduardKrieger in https://github.com/devonfw/cobigen/pull/1633#discussion_r1154422856_
Check: https://github.com/devonfw/cobigen/blob/5af0844d45ae470c47c819234f248c6e72f8baff/cobigen/cobigen-core/src/test/java/com/devonfw/cobigen/unittest/config/upgrade/TemplateSetUpgraderTest.java#L65-L114
Check: https://github.com/devonfw/cobigen/blob/5af0844d45ae470c47c819234f248c6e72f8baff/cobigen/cobigen-core-systemtest/src/test/java/com/devonfw/cobigen/systemtest/TemplateProcessingTest.java#L115-L142 Make sure that binaries used in this test get replaced with a test project.
Do we need a call of the upgrader at each intialization of cobigen? _Originally posted by @EduardKrieger in https://github.com/devonfw/cobigen/pull/1633#discussion_r1154707591_
### Expected behavior Template sets should provide all dependencies which were in the old monolithic templates like before: https://github.com/devonfw/cobigen/blob/28f53b0dad58ff71b30d011f0a0dfe450f646313/cobigen-templates/templates-devon4j-utils/pom.xml#L17-L47 ### Actual behavior Current template sets provide dependencies only from this:...
Check: https://github.com/devonfw/cobigen/blob/5af0844d45ae470c47c819234f248c6e72f8baff/cobigen-eclipse/cobigen-eclipse/src/com/devonfw/cobigen/eclipse/workbenchcontrol/handler/GenerateJob.java#L69-L70
Check: https://github.com/devonfw/cobigen/blob/f3a43994b1dfa115781ba920309ee97324bed091/cobigen/cobigen-core-systemtest/src/test/java/com/devonfw/cobigen/systemtest/ClassLoadingIT.java#L154-L178
Replace all of these binaries with test projects: - cobigen/cobigen-core-systemtest/src/test/resources/testdata/systemtest/AdaptMonolithicTemplatesTest/templates/templates-devon4j-0.0.1-sources.jar - cobigen/cobigen-core-systemtest/src/test/resources/testdata/systemtest/AdaptMonolithicTemplatesTest/templates/templates-devon4j-0.0.1.jar - cobigen/cobigen-core-systemtest/src/test/resources/testdata/systemtest/AdaptTemplateSetsTest/template-sets/downloaded/template-test1-0.0.1.jar - cobigen/cobigen-core-systemtest/src/test/resources/testdata/systemtest/AdaptTemplateSetsTest/template-sets/downloaded/template-test1-0.0.1_old.jar - cobigen/cobigen-core-systemtest/src/test/resources/testdata/systemtest/AdaptTemplateSetsTest/template-sets/downloaded/template-test2-0.0.1.jar - cobigen/cobigen-core-systemtest/src/test/resources/testdata/systemtest/TemplateScanTest/valid.zip Hint: Create test projects like this: https://github.com/devonfw/cobigen/blob/f7f16ec03d61fc419621f998ddb1fbc385e4ff19/cobigen/cobigen-core-systemtest/src/test/resources/testdata/systemtest/GenerationTestTemplateSetsXml/template-sets/downloaded/downloaded1-test/pom.xml#L1-L27 https://github.com/devonfw/cobigen/blob/f7f16ec03d61fc419621f998ddb1fbc385e4ff19/cobigen/cobigen-core-systemtest/pom.xml#L7-L12 https://github.com/devonfw/cobigen/blob/f7f16ec03d61fc419621f998ddb1fbc385e4ff19/cobigen/cobigen-core-systemtest/pom.xml#L56-L80
Check if TemplateSetConfigurationManager can/should be integrated into TemplateSetConfigurationReader. https://github.com/devonfw/cobigen/blob/28f53b0dad58ff71b30d011f0a0dfe450f646313/cobigen/cobigen-core/src/main/java/com/devonfw/cobigen/impl/config/reader/TemplateSetConfigurationManager.java#L22-L42 https://github.com/devonfw/cobigen/blob/28f53b0dad58ff71b30d011f0a0dfe450f646313/cobigen/cobigen-core/src/main/java/com/devonfw/cobigen/impl/config/reader/TemplateSetConfigurationReader.java#L43-L53
The context upgrader is splitting and after that merging the context.xml with the template.xml so it would be great to upgrade all the templates first with a TemplateConfigurationUpgrader and after...