David Widmann

Results 1463 comments of David Widmann

I'm not sure anymore if it's a good idea to update the residuals at all. I guess I assumed it would be needed for the convergence/divergence checks, but if the...

I just came across this PR since I noticed that my implementation of `istable(::Type{

I just noticed that the PR was made against and merged into master instead of main. That seems incorrect?

I get quite different benchmark results, for the example in Distances, the 3-argument version seems to be faster (and, of course, avoid the allocation): ```julia julia> using LinearAlgebra, BenchmarkTools julia>...

Yes, I can confirm that at some point the current implementation becomes faster. Would it make sense to add an empirical cutoff in the `dot3args` function suggested above?

Although it sounds difficult to come up with good threshold values for arbitrary vector and matrix (not possible currently, but I guess the type constraints of SqMahalanobis could be relaxed?)...

FYI: https://github.com/JuliaOptimalTransport/OptimalTransport.jl contains specialized implementations for the 1D solution, both for discrete and continuous distributions, but also a pure Julia implementation for solving the optimal transport problem with discrete measures...

FYI: https://github.com/JuliaOptimalTransport/OptimalTransport.jl contains specialized implementations for the 1D solution, both for discrete and continuous distributions, but also a pure Julia implementation for solving the optimal transport problem with discrete measures...

We started splitting OptimalTransport.jl into smaller subpackages, the Wasserstein distances, based on MOI in the general case and including special cases as 1D and e.g. Gaussian distributions, are moved to...

Yes, this is definitely a strong argument against changing any of these function signatures. The main motivation for this PR is that [`pairwise!` is not owned by Distances anymore](https://github.com/JuliaStats/Distances.jl/pull/213) and...