David Widmann

Results 1463 comments of David Widmann

Do you have an example for what you tried and how it failed?

Sorry, it's still unclear to me where exactly you put these lines of code and how you called them. Do you have a MWE or a link to a repo?

Ah OK, and do you have a MWE that I can run to reproduce the issue?

Thanks for the MWE, I'll have a look at it. In principle, I think the right approach is to add support for convergence based logging upstream in ProgressLogging, as you...

I don't think this has to or should be couple to a PPL. For instance, for algorithm 2 it seems one just needs to provide functions that sample from the...

> The functions currently assume draws are in a single array with shape (draws, chains, params) They either work with vectors of draws or arrays of shape (draws, params, chains).

No, it's not supported by `ess_rhat`. All functions either work with vectors or arrays of shape (draws, chains, params), but not both.

I don't think this package should support different permutations. IMO we need a clearly documented and consistent choice for such situations but then users have to permute the arrays if...

I should add that I don't think we have to stick with the current convention but it would be good to be consistent for 3d arrays. I guess the choice...

Please no, let's just stick with generic `AbstractArray`s - one main motivation here is to get rid of the Chains/AxisArrays mess and just be as generic as possible.