Kakapo.js icon indicating copy to clipboard operation
Kakapo.js copied to clipboard

Passing status code, options to Response() constructor

Open palashkaria opened this issue 7 years ago • 2 comments

Added a new field to KakapoResponse, options, which is being passed on the window.Response(body, options). It can have statusText, status (codes), and headers, and currently we are only passing headers.

see #144 for a detailed explanation on why I suggest we do this, & another idea to being the fetchInterceptor behaviour closer to window.fetch

palashkaria avatar Jan 19 '18 13:01 palashkaria

Codecov Report

Merging #143 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #143   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files          21       21           
  Lines         791      791           
=======================================
  Hits          779      779           
  Misses         12       12
Impacted Files Coverage Δ
src/interceptors/fetchInterceptor.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8230a01...0d1bc49. Read the comment docs.

codecov-io avatar Jan 19 '18 13:01 codecov-io

Looks good to me, can you please add tests for it? afterwards I will more than happy to merge

zzarcon avatar Jan 20 '18 07:01 zzarcon