moq icon indicating copy to clipboard operation
moq copied to clipboard

`EmptyDefaultValueProvider` should support `IReadOnlyCollection`

Open coenvk opened this issue 3 years ago • 3 comments

The EmptyDefaultValueProvider should support IReadOnlyCollection

Back this issue Back this issue

coenvk avatar Sep 30 '22 15:09 coenvk

Hi @stakx, is anyone working on this one? I would like to take it.

fndejan avatar Oct 04 '22 21:10 fndejan

Hi @fndejan, no, noone is working on this right now. This (or something very similar) has been requested before, so please be aware of https://github.com/moq/moq4/issues/173#issuecomment-347695892. I can definitely see the sense behind supporting newer common collection types, and I'm a little more willing than back then to make reasonable breaking changes... but EmptyDefaultValueProvider is such a core part of Moq that it has the potential to break lots of existing code. Therefore I'm still undecided whether or not such a change should be merged. I'd like to think this through and try to weigh possible consequences more carefully.

stakx avatar Oct 04 '22 22:10 stakx

Due to lack of recent activity, this issue has been labeled as 'stale'. It will be closed if no further activity occurs within 30 more days. Any new comment will remove the label.

github-actions[bot] avatar Aug 24 '24 20:08 github-actions[bot]

Due to lack of recent activity, this issue has been labeled as 'stale'. It will be closed if no further activity occurs within 30 more days. Any new comment will remove the label.

github-actions[bot] avatar Apr 04 '25 01:04 github-actions[bot]

This issue will now be closed since it has been labeled 'stale' without activity for 30 days.

github-actions[bot] avatar May 05 '25 01:05 github-actions[bot]