gridlex icon indicating copy to clipboard operation
gridlex copied to clipboard

Nested grids do not work

Open thorinmesser opened this issue 7 years ago • 4 comments

You can see this on the project home page, the nested grid example there does not work. I think due to line 193 of gridlex.scss where it sets every child of grid that isn't set to "0" to display block (I think), but the nested grid wants to be display flex.

thorinmesser avatar Sep 08 '17 17:09 thorinmesser

So this is weird, suddenly they work for me in my project. Please ignore me.

thorinmesser avatar Sep 08 '17 18:09 thorinmesser

Ok, don't ignore me. I was autoresponding and my local npm was using 2.4.0 as I have specified but my build server was using 2.4.1, and 2.4.1 does not work with nested grids as explained above.

thorinmesser avatar Sep 08 '17 20:09 thorinmesser

I'm having the same issue- even when I use the examples from the Docs.

davidchameleon avatar Oct 24 '17 10:10 davidchameleon

the odd thing is, this appears to be known problem which is accounted for by the commented code [1] which is pretty specific in saying "grids which aren't hidden by -0 for the given media query should be display: flex". i can't think of where this can ever cause undesirable behavior.

@devlint any reason why this remains off? 😕

[1] https://github.com/devlint/gridlex/blob/ee4f7bb25a62de472839b01ed9cc1bfb80f31e97/src/gridlex.scss#L195-L197

leeoniya avatar Oct 26 '17 06:10 leeoniya