devlauer
Jakarta namespace update
Hello,
Would you take a PR on a jakarta update for addJPAAnnotations and addJavaxAnnotations ?
I'm thinkinf of
- For addJPAAnnotations, simply adding jakarta.* annotation search in JPAAnalyzerHelper and allowing both on the doc
- For addJavaxAnnotations, doing one or more of :
- Renaming the parameter to addJavaBeanAnnotations (breaking change, but I may be the only one using it)
- Renaming the docs to addJavaBeanAnnotations
- Adding jakarta.* annotation search in JavaxValidationAnalyzerHelper
What do you think ? Regards
An additional consideration of the jakarta namespace makes sense, because sooner or later all users switch to it. That you rename in this case the method addJavaxAnnotations as well as the associated internal methods and the class JavaxValidationAnalyzerHelper likewise. Regarding the breaking change I would like to see a hint in the documentation, so that other potential users know what to change to. In this respect I would adopt the PR.
Hello !
Not a lot of time on my hand lately, I made a PR for the (easy) JPA Annotation part : https://github.com/devlauer/plantuml-generator/pull/140
Let me know !
Sorry for the delayed answer! Thanks you very much for your contribution! I've merged your PR and created a new version (2.4.0), which should be available in the next hours.
@Maxouwell : Thank you very much for your contribution! And I am really sorry for the long wait! I released both pull requests as part of version 3.0.1. This version should be available within the next hours.