libogc icon indicating copy to clipboard operation
libogc copied to clipboard

Add GX_SetTevIndWarp Function

Open gamemasterplc opened this issue 5 years ago • 9 comments

The function provides a wrapper to GX_SetTevIndirect to warp indirect textures more easily. The function is also undocumented at the moment.

gamemasterplc avatar Jun 17 '19 03:06 gamemasterplc

Merge it @WinterMute

gamemasterplc avatar Jun 18 '19 13:06 gamemasterplc

Merge it @WinterMute

This is not appropriate use of the issue trackers. Please don't make demands of maintainers.

WinterMute avatar Jun 18 '19 13:06 WinterMute

Would someone please merge this pull request for me because I can't merge it.

gamemasterplc avatar Jun 18 '19 17:06 gamemasterplc

It's not appropriate to demand that PRs get merged, please exercise some patience. 1 day block applied.

WinterMute avatar Jun 18 '19 18:06 WinterMute

I'm curious what the PR is waiting on. There doesn't seem to be any reason not to merge it, afaict.

endrift avatar Jun 18 '19 18:06 endrift

I'm curious what the PR is waiting on. There doesn't seem to be any reason not to merge it, afaict.

When the temporary ban gets lifted then it would be appropriate to have an example illustrating the use of the wrapper. Demanding that PRs get merged immediately is disrespectful, we have many other things that require attention and rude users will be deprioritised.

WinterMute avatar Jun 18 '19 18:06 WinterMute

I've written some code using the wrapper at https://github.com/gamemasterplc/warpdemo/blob/master/source/warpdemo.c . The code includes the wrapper itself and bends a fullscreen texture using an indirect texture map.

gamemasterplc avatar Jun 19 '19 18:06 gamemasterplc

Maybe that should be added to the examples repository after this is merged.

endrift avatar Jun 19 '19 18:06 endrift

It can as long as I am credited for creating it @endrift

gamemasterplc avatar Jun 19 '19 20:06 gamemasterplc

Merged. next time @gamemasterplc, don't be so rude to people if you can. this is what you get then

DacoTaco avatar Jan 22 '23 08:01 DacoTaco