libogc icon indicating copy to clipboard operation
libogc copied to clipboard

DSP task code incorrectly sets flags instead of state in one case

Open Pokechu22 opened this issue 2 years ago • 0 comments

https://github.com/devkitPro/libogc/blob/6c104219be4f3741c59446948052311a405de7cf/libogc/dsp.c#L251

I'm pretty sure this should be __dsp_currtask->state = DSPTASK_YIELD as that's what's done in the other yield cases. The corresponding bit in flags would be __dsp_currtask->flags = DSPTASK_CANCEL which seems wrong.

I don't know if this affects anything in practice.

Pokechu22 avatar Jun 22 '22 18:06 Pokechu22