gba-examples icon indicating copy to clipboard operation
gba-examples copied to clipboard

Is there a specific reason why -mcpu definition is set to CFLAGS instead of ARCH?

Open FluBBaOfWard opened this issue 2 years ago • 2 comments

ARCH	:=	-mthumb -mthumb-interwork

CFLAGS	:=	-g -Wall -O2\
		-mcpu=arm7tdmi -mtune=arm7tdmi\
		$(ARCH)

I can make a pull request for all makefiles if it's ok.

FluBBaOfWard avatar Oct 15 '22 09:10 FluBBaOfWard

I'd kindly like to point out that you're looking at probably one of the oldest collections of code produced by devkitPro. There have been a good number of lessons learned over the past decades, and the exact details and rationale for certain things are not always recoverable, especially the farther you go back in time.

A more appropiate ARCH setting for the GBA that follows our latest practices is probably -march=armv4t -mtune=arm7tdmi -mthumb -mthumb-interwork - in fact, that's what the GBA support recently added to devkitPro CMake uses.

fincs avatar Oct 20 '22 17:10 fincs

So should I do a PR?

FluBBaOfWard avatar Oct 21 '22 15:10 FluBBaOfWard