Jiwon Choi

Results 107 comments of Jiwon Choi

@ijjk Understood. Can I have a day for the last try? 😊 Edit: All tests pass, successful w/o bundling, will work on refactor & reducing fs operations!

@ijjk Thank you for waiting! Current change meets the major expectations we discussed before: - no bundling - no restrictions - less fs operations and writing on disk (readFile only)

* **#71308** 👈 * `canary` This stack of pull requests is managed by Graphite. Learn more about stacking. Join @devjiwonchoi and the rest of your teammates on Graphite

Yeah I'll add prompt for `geo-ip` codemod that it requires `@vercel/functions`. If yes, will just install if changed.

> What does "type-safe" mean here? When would type-checking now fail when it passed previously? type-safe -> *type-checking > Why focus on dev env variables? It's more like **not including...

@eps1lon Type-checking allows autocompletion, and validate the env was loaded (no need assumption like `as string` or `notNull!`. ![Screenshot 2024-07-09 at 12 43 56 AM](https://github.com/vercel/next.js/assets/120007119/90976583-c4b8-4e54-a003-ff009e06615c) Updated the description as well....

Since `process.env` members are `string | undefined` we needed an extra layer to use it if required argument's type was strictly a string. ```ts const foo = (str: string) =>...

* **#80457** : 2 dependent PRs ([#80460](https://github.com/vercel/next.js/pull/80460) , [#80619](https://github.com/vercel/next.js/pull/80619) ) * **#80456** 👈 (View in Graphite) * **#80251** * `canary` This stack of pull requests is managed by Graphite. Learn...

* **#12906** 👈 (View in Graphite) * `main` This stack of pull requests is managed by Graphite. Learn more about stacking.