devito icon indicating copy to clipboard operation
devito copied to clipboard

benchmarks should use argparse, not an external dependency like click

Open FabioLuporini opened this issue 6 years ago • 6 comments

and this is what you can use for so called "choice" parameters : http://click.pocoo.org/5/options/#basic-value-options

I thought about this when I saw the option --noazimuth in the TTI example

potentially work for the UROP

FabioLuporini avatar May 08 '18 06:05 FabioLuporini

Not sure why this is better

mloubout avatar May 10 '18 20:05 mloubout

it's more powerful and it would make it straightforward to reuse stuff across different examples (eg, isotropic and tti share lots of options)

benchmark.py also uses CLI, and it's good practice to have homogeneous code

FabioLuporini avatar May 15 '18 07:05 FabioLuporini

Should I incoroporate this in #1257 ?

georgebisbas avatar Apr 30 '20 05:04 georgebisbas

From issues that popped up with ltest click version, the opposite may have to be considered for future stability and replacing back click options by arg_parse. See #1832

mloubout avatar Feb 01 '22 13:02 mloubout

In retrospect, I agree

FabioLuporini avatar Aug 21 '23 07:08 FabioLuporini

updating title to reflect

FabioLuporini avatar Aug 21 '23 07:08 FabioLuporini