devito
devito copied to clipboard
benchmarks should use argparse, not an external dependency like click
and this is what you can use for so called "choice" parameters : http://click.pocoo.org/5/options/#basic-value-options
I thought about this when I saw the option --noazimuth in the TTI example
potentially work for the UROP
Not sure why this is better
it's more powerful and it would make it straightforward to reuse stuff across different examples (eg, isotropic and tti share lots of options)
benchmark.py
also uses CLI, and it's good practice to have homogeneous code
Should I incoroporate this in #1257 ?
From issues that popped up with ltest click version, the opposite may have to be considered for future stability and replacing back click
options by arg_parse
. See #1832
In retrospect, I agree
updating title to reflect