devito icon indicating copy to clipboard operation
devito copied to clipboard

examples: Refactor wavelets

Open JDBetteridge opened this issue 2 months ago • 3 comments

In response to being told to create the examples.RickerSource object, whenever I redefined it as a function.

JDBetteridge avatar Oct 16 '25 22:10 JDBetteridge

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Codecov Report

:x: Patch coverage is 35.21127% with 46 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 53.24%. Comparing base (3169bb5) to head (6751e07).

Files with missing lines Patch % Lines
examples/seismic/source.py 35.21% 39 Missing and 7 partials :warning:

:exclamation: There is a different number of reports uploaded between BASE (3169bb5) and HEAD (6751e07). Click for more details.

HEAD has 10 uploads less than BASE
Flag BASE (3169bb5) HEAD (6751e07)
18 8
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2770       +/-   ##
===========================================
- Coverage   83.04%   53.24%   -29.81%     
===========================================
  Files         248      248               
  Lines       50469    50511       +42     
  Branches     4440     4452       +12     
===========================================
- Hits        41913    26895    -15018     
- Misses       7795    22640    +14845     
- Partials      761      976      +215     
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 68.67% <35.21%> (-0.06%) :arrow_down:
pytest-gpu-nvc-nvidiaX 69.21% <35.21%> (-0.05%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Oct 16 '25 22:10 codecov[bot]

Also see ##2743, there is a tiny discretization issue that makes the discrete wavelet non-zero mean, which can be problematic.

mloubout avatar Oct 17 '25 12:10 mloubout