devito icon indicating copy to clipboard operation
devito copied to clipboard

Operator._prepare_arguments needs refactoring to remove Thickness loop

Open EdCaunt opened this issue 1 year ago • 0 comments

Operator._prepare_arguments currently contains the following lines:

# Process Thicknesses
for p in self.parameters:
    if isinstance(p, Thickness):
    args.update(p._arg_values(grid=grid, **kwargs))

which could be removed by making Thickness have is_Input = True and moving grid processing to before _arg_values is called on inputs.

However, as pending PRs make changes to this code, this should be returned to later to avoid messy merge conflicts.

EdCaunt avatar Nov 13 '24 14:11 EdCaunt