devito icon indicating copy to clipboard operation
devito copied to clipboard

dependencies: sympy 1.11 compatibility

Open mloubout opened this issue 1 year ago • 2 comments

Small PR than fixes the newly introduced bug in sympy for _print_Add. We should keep that bug fix in our printer even once 1.12 is released so that we stay compatible with sympy 1.11

mloubout avatar Sep 21 '22 13:09 mloubout

Codecov Report

Merging #2005 (367e1c3) into master (6e1dcc5) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2005   +/-   ##
=======================================
  Coverage   87.85%   87.85%           
=======================================
  Files         214      214           
  Lines       36710    36727   +17     
  Branches     5550     5554    +4     
=======================================
+ Hits        32250    32267   +17     
  Misses       3942     3942           
  Partials      518      518           
Impacted Files Coverage Δ
devito/symbolics/printer.py 82.92% <100.00%> (+2.73%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 21 '22 13:09 codecov[bot]

and ready to go

No there is still a bug with str(expr) looking into best way to fix it

mloubout avatar Sep 22 '22 14:09 mloubout