devito icon indicating copy to clipboard operation
devito copied to clipboard

devito setup.py installs top-level package just named 'examples' into site-packages

Open tjb900 opened this issue 2 years ago • 5 comments

I would argue this should at the very least be called devito_examples or something along those lines? Same with benchmarks.

tjb900 avatar Aug 18 '21 02:08 tjb900

Yes it is an issue. It is on the TODO list but we not sure how to proceed without completely breaking backward compatibility. It does need proper name change and/or restructuring of the repo.

mloubout avatar Aug 18 '21 11:08 mloubout

Ah, yeah - backward compatibility... One option to kick off the process might be to start raising a DeprecationWarning/FutureWarning when the modules are imported? Will happily submit a patch for that if you think it's a good idea.

tjb900 avatar Aug 18 '21 23:08 tjb900

Yes would be the idea, just not sure how long making it a warning before moving it permanently. In theory people who have example installed should still have it after the move but is a bit wishy.

mloubout avatar Aug 18 '21 23:08 mloubout

@mloubout was that related to the gempy notebook breakage?

georgebisbas avatar Nov 10 '21 14:11 georgebisbas

yes

mloubout avatar Nov 10 '21 15:11 mloubout