Redundant arguments for AcousticWaveSolver

[philippwitte]

When looking at the dask tutorial, I noticed that AcousticWaveSolver takes a model and a geometry structure as input arguments. However, geometry already contains a model structure itself. Is it therefore necessary to pass both arguments instead of just passing geometry? Otherwise it's not clear which one is used for what.

Another thing I noticed is that it's possible to pass a geometry structure to AcousticWaveSolver which contains the coordinates for multiple sources. However, when you call the solver, it only returns results for the first source position. I think it would be good to either have a loop over shots in AcousticWaveSolver or throw an error (or at least a warning) if you pass it a geometry object with more than one source.

[FabioLuporini]

I've assigned this to Mathias because usually he's the one taking care of the examples.

However, I do see what you mean, and yes, I think you're right, there's definitely some clean up that we should do. If you already have a patch in your mind, please don't be shy and file a PR :D

[FabioLuporini]

@mloubout @philippwitte is this still an issue today? we've merged quite a few PRs that might have improved the situation

[FabioLuporini]

ping @mloubout @philippwitte

[FabioLuporini]

ping @mloubout

[mloubout]

I think it's still there as a legacy feature but throws a warning.