bsnes-plus icon indicating copy to clipboard operation
bsnes-plus copied to clipboard

Memory Editor thinks VRAM is byte-addressed

Open jeffythedragonslayer opened this issue 2 years ago • 4 comments

When the Memory Editor is viewing S-PPU VRAM, there are 16 bytes per row. The second row is labeled "0010" (which is hex for 16) which means that this Memory Editor window is displaying the VRAM as byte-addressed. But the SNES has word-addressed VRAM. The "Address:" label in the bottom panel has the same problem.

image

jeffythedragonslayer avatar Jun 27 '22 17:06 jeffythedragonslayer

The Address field and Selected Tile Address label in the Tile Viewer also have this problem.

jeffythedragonslayer avatar Jun 29 '22 16:06 jeffythedragonslayer

This has always been intentional - partly just to make VRAM addressing consistent with everything else, and also since VRAM is still read/written as bytes instead of words behind the scenes.

I think it wouldn't be a bad idea to have an option to use word addressing for VRAM instead, but I'd probably make it non-default just to avoid breaking the existing convention.

devinacker avatar Jun 29 '22 16:06 devinacker

Does that default of byte-addressing make anyone's workflow easier? I think keeping it byte-addressed makes it harder for people developing games because the addresses they're seeing aren't what they need to set VMADDL and VMADDH to in order to read/write VRAM.

jeffythedragonslayer avatar Jun 29 '22 16:06 jeffythedragonslayer

I agree with @jeffythedragonslayer. At least an option to have VRAM word addressing in bsnes-plus would make things sooooo much less confusing, and more consistent, with a reasonably normal programming/debugging workflow. :-)

Ramsis-SNES avatar Jul 23 '22 17:07 Ramsis-SNES