devicon icon indicating copy to clipboard operation
devicon copied to clipboard

new icon: huggingface (original, original-wordmark, plain, plain-wordmark, line, line-wordmark)

Open weh opened this issue 5 months ago • 3 comments

Double check these details before you open a PR

  • [x] PR does not match another non-stale PR currently opened
  • [x] PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • [x] PR's base is the develop branch.
  • [x] Your icons are inside a folder as seen here
  • [x] SVG matches the standards laid out here
  • [x] A new object is added in the devicon.json file at the correct alphabetic position as seen here

This PR closes #1126

Link to prove your SVG is correct and up-to-date.

https://huggingface.co

weh avatar Jul 08 '25 16:07 weh

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files: Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs: Imgur Images Imgur Images Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon: Imgur Images

Here are the zoomed-in screenshots of the added icons as icons: Imgur Images Imgur Images Imgur Images Imgur Images

Here are the colored versions: Imgur Images Imgur Images Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)
  4. A new object is added in the devicon.json file at the correct alphabetic position as seen here

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers, Peek Bot :blush:

github-actions[bot] avatar Jul 08 '25 17:07 github-actions[bot]

Traceback (most recent call last):
list index out of range
  File "/home/runner/work/devicon/devicon/.github/scripts/build_assets/util.py", line 65, in find_object_added_in_pr
    icon_name = pattern.findall(pr_title)[icon_name_index].lower().strip()  # should only have one match
IndexError: list index out of range

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "./.github/scripts/check_icon_pr.py", line 27, in main
    filtered_icon = util.find_object_added_in_pr(all_icons, args.pr_title)
  File "/home/runner/work/devicon/devicon/.github/scripts/build_assets/util.py", line 72, in find_object_added_in_pr
    raise Exception(message)
Exception: util.find_object_added_in_pr: Couldn't find an icon matching the name in the PR title.
PR title is: 'new icon: huggingface (original, original-wordmark, plain, plain-word…'

When you rename the PR title, manually re-running the workflow won't fix this because GitHub is using the same context as the last run. If you sync the branch it should correct.

ReenigneArcher avatar Jul 28 '25 03:07 ReenigneArcher

When you rename the PR title, manually re-running the workflow won't fix this because GitHub is using the same context as the last run. If you sync the branch it should correct.

A rebase did help here :smile:

weh avatar Jul 28 '25 08:07 weh