new icon: laminas (original, original-wordmark, line, line-wordmark)
Double check these details before you open a PR
- [x] PR does not match another non-stale PR currently opened
- [x] PR name matches the format new icon: Icon name (versions separated by comma). More details here
- [x] PR's base is the
developbranch. - [x] Your icons are inside a folder as seen here
- [x] SVG matches the standards laid out here
- [x] A new object is added in the
devicon.jsonfile at the correct alphabetic position as seen here
This PR closes #2234
Link to prove your SVG is correct and up-to-date.
https://getlaminas.org/
@canaleal Thank you for your thorough review. I've addressed all the points you raised:
-
icons/laminas/laminas-line.svg:
- Scaled the SVG to 128 to reach the edges of the viewbox.
-
icons/laminas/laminas-line-wordmark.svg:
- Converted all strokes to paths.
-
devicon.json:
- Added 'original-wordmark', 'line', and 'line-wordmark' to the font versions.
- Updated the aliases section as suggested:
"aliases": [ { "base": "original", "alias": "plain" }, { "base": "original-wordmark", "alias": "plain-wordmark" } ]
I've committed these changes and pushed them to the repository. The pull request now shows 2 commits. Could you please review the changes again? Let me know if any further modifications are needed.
No artifacts and all SVGs are good. Great work:
Hi!
I'm the check-bot and we have some issues with your PR:
devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60
Check our CONTRIBUTING guide for more details regarding these errors.
Please address these issues. When you update this PR, I will check your SVGs again.
Thanks for your help, SVG-Checker Bot :smile: