devicon icon indicating copy to clipboard operation
devicon copied to clipboard

update icon: appwrite (original, original-wordmark, plain, plain-wordmark)

Open Yashh56 opened this issue 1 year ago • 11 comments

Close #2181

Yashh56 avatar May 23 '24 16:05 Yashh56

Hey Maintainer Please Review this PR

Yashh56 avatar Jun 07 '24 12:06 Yashh56

Thanks @Snailedlt for reviewing this PR Can you tell me how to resolve this issue ?

Yashh56 avatar Jun 07 '24 16:06 Yashh56

Thanks @Snailedlt for reviewing this PR Can you tell me how to resolve this issue ?

@Yashh56 I think the easiest way is downloading the official icons again and making sure that the aspect ratio is maintained when you resize it :)

If you're using inkscape you can follow this guide when resizing: https://github.com/devicons/devicon/issues/1306#issuecomment-1296051881

PS: there's lots of other great guides in that issue as well!

Snailedlt avatar Jun 07 '24 17:06 Snailedlt

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot :smile:

github-actions[bot] avatar Jun 08 '24 11:06 github-actions[bot]

Hey Maintainer Please Review this PR

Yashh56 avatar Jun 15 '24 14:06 Yashh56

...also original and plain could be aliased since it is only a single color (?)

weh avatar Jun 17 '24 07:06 weh

And i forgot also that the original and plain should not have that much spacing around the icon. So to summarize again:

  • Fix the squished aspect ratio
  • Remove the spacing around the Icon
  • Remove the plain-wordmark / original-wordmark alias
        "aliases": [
            {
                "base": "plain",
                "alias": "original"
            }
        ]

weh avatar Jun 17 '24 08:06 weh

Refer to guides under this issue as well as the wiki if you're unsure how to fix the issues :)

Snailedlt avatar Jun 17 '24 11:06 Snailedlt

how can i squished aspect ratio ?

Yashh56 avatar Jun 17 '24 11:06 Yashh56

I used Resize to resize the aspect ratio

Yashh56 avatar Jun 17 '24 11:06 Yashh56

@Yashh56 If you're using inkscape, make sure you check the box to scale proportionally image Otherwise the svg will get stretched to fit the viewbox.

Here's two different guides to resize to a square. Both can be found as comments in the issue I linked to earlier:

  • https://github.com/devicons/devicon/pull/1938#discussion_r1378205483
  • https://github.com/devicons/devicon/pull/1465#issuecomment-1287950577

Snailedlt avatar Jun 17 '24 11:06 Snailedlt

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot :smile:

github-actions[bot] avatar Oct 24 '24 03:10 github-actions[bot]

Hey @Snailedlt, Can you review my changes :)

Yashh56 avatar Oct 26 '24 03:10 Yashh56

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot :smile:

github-actions[bot] avatar Dec 23 '24 02:12 github-actions[bot]

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot :smile:

github-actions[bot] avatar Dec 23 '24 02:12 github-actions[bot]