devicon icon indicating copy to clipboard operation
devicon copied to clipboard

new icon: StencilJS (original, original-wordmark)

Open gitChaoslord opened this issue 1 year ago • 4 comments

Double check these details before you open a PR

  • [x] PR does not match another non-stale PR currently opened
  • [x] PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • [x] PR's base is the develop branch.
  • [x] Your icons are inside a folder as seen here
  • [x] SVG matches the standards laid out here
  • [x] A new object is added in the devicon.json file at the correct alphabetic position as seen here

This PR closes #866

Link to prove your SVG is correct and up-to-date.

The SVGs can be found here by downloading the "full press kit" at the bottom of page.

I've manipulated the downloaded SVGs using the following tools

  • Resizing : https://mediamodifier.com/svg-editor
  • Cleanup : https://jakearchibald.github.io/svgomg/

gitChaoslord avatar Feb 26 '24 20:02 gitChaoslord

Hello @canaleal, thank you!

I've made some adjustments based on your input.

  • Removed the "colored" word from the icon names
  • I've decided to name the "black" logo as plain and the "white" as original, ( My reason was the white also had an opacity attribute on one element )
  • Made sure the contents are centered
  • Removed all padding on the X axis ( Y axis has some padding left to prevent distortion )

gitChaoslord avatar Feb 28 '24 00:02 gitChaoslord

Hello again @canaleal

I've performed the requested changes as per your instructions

  • Corrected the color in devicons.json
  • Removed original & original-wordmark from the font version
  • Unified the plain & plain-workmark paths into a single one
  • Formatted file contents to be in the first line and added a second empty line

Let me know if there is anything else missing

gitChaoslord avatar Mar 03 '24 20:03 gitChaoslord

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60



Error found regarding filenames:
- This path doesn't exist: '/home/runner/work/devicon/devicon/icons/stenciljs/stenciljs-original-wordmark.svg'

Error checking SVGs: no SVGs to check. Might be caused by above issues.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot :smile:

github-actions[bot] avatar Mar 03 '24 23:03 github-actions[bot]

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot :smile:

github-actions[bot] avatar Mar 03 '24 23:03 github-actions[bot]

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot :smile:

github-actions[bot] avatar May 25 '24 09:05 github-actions[bot]