devicon icon indicating copy to clipboard operation
devicon copied to clipboard

new icon: aerospike (original, original-wordmark)

Open ah-aliakbarpour opened this issue 1 year ago • 7 comments

Double check these details before you open a PR

  • [x] PR does not match another non-stale PR currently opened
  • [x] PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • [x] PR's base is the develop branch.
  • [x] Your icons are inside a folder as seen here
  • [x] SVG matches the standards laid out here
  • [x] A new object is added in the devicon.json file as seen here

This PR closes #2110

Link to prove your SVG is correct and up-to-date.

https://aerospike.com/

ah-aliakbarpour avatar Jan 14 '24 14:01 ah-aliakbarpour

Thank you for reviewing!

I deleted the aerospike-plain.svg and pushed changes.

ah-aliakbarpour avatar Jan 16 '24 11:01 ah-aliakbarpour

@canaleal , What is the problem with requested changes?

ah-aliakbarpour avatar Jan 22 '24 10:01 ah-aliakbarpour

Well, when will this PR be merged?

ah-aliakbarpour avatar Feb 05 '24 08:02 ah-aliakbarpour

Well, when will this PR be merged?

the main focus was currently on the Release https://github.com/devicons/devicon/releases/tag/v2.16.0 so i guess this will happen soon, and is just a matter of time. From your side, this MR is OK and ready, it has the needed reviews, so nothing to do left :+1:

weh avatar Feb 07 '24 11:02 weh

Thanks @weh.

ah-aliakbarpour avatar Feb 07 '24 11:02 ah-aliakbarpour

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot :smile:

github-actions[bot] avatar Feb 17 '24 17:02 github-actions[bot]

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot :smile:

github-actions[bot] avatar Feb 17 '24 18:02 github-actions[bot]