devicon icon indicating copy to clipboard operation
devicon copied to clipboard

update icon: npm (original, plain)

Open m00nbyte opened this issue 2 years ago • 6 comments

Double check these details before you open a PR

  • [x] PR does not match another non-stale PR currently opened
  • [x] PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • [x] PR's base is the develop branch.
  • [x] Your icons are inside a folder as seen here
  • [x] SVG matches the standards laid out here
  • [x] A new object is added in the devicon.json file as seen here

Link to prove your SVG is correct and up-to-date.

m00nbyte avatar Dec 14 '23 22:12 m00nbyte

@m00nbyte The original-wordmark.svg still exists in the versions, but there is no original-wordmark.svg file. image

Also, although npm uses the square version of the logo, they also still make use of the wordmark version as seen on their website and is found in this archived repo.

canaleal avatar Feb 22 '24 15:02 canaleal

@canaleal this was already in the devicon.json before my PR and i can see that this file exists: https://github.com/devicons/devicon/blob/master/icons/npm/npm-original-wordmark.svg

image

m00nbyte avatar Feb 22 '24 19:02 m00nbyte

@m00nbyte Correct, what I meant to say is that our version is not correct and should be changed. As @Snailedlt mentioned above, our version has transparent text while the original has white text.

canaleal avatar Feb 22 '24 20:02 canaleal

@canaleal ok i see, are those two icons i've added correct?

m00nbyte avatar Feb 22 '24 20:02 m00nbyte

@m00nbyte Both icons look nearly perfect.

They're scaled up a little too much with a height and width of 128.005 image

And the plain icon also has a stroke width. image

Aside from those 2 things, they're good.

canaleal avatar Feb 22 '24 20:02 canaleal

@canaleal i removed the stroke-width but the size of the icons are 128px. i looked at them in multiple programs and the viewbox is also limited to 128px so i have no idea how you get 128.005px.

m00nbyte avatar Mar 30 '24 13:03 m00nbyte

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot :smile:

github-actions[bot] avatar Jul 27 '24 09:07 github-actions[bot]