devicon icon indicating copy to clipboard operation
devicon copied to clipboard

update icon: angular (original, original-wordmark, plain, plain-wordmark)

Open gabrielfins opened this issue 2 years ago • 4 comments

Double check these details before you open a PR

  • [x] PR does not match another non-stale PR currently opened
  • [x] PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • [x] PR's base is the develop branch.
  • [x] Your icons are inside a folder as seen here
  • [x] SVG matches the standards laid out here
  • [x] A new object is added in the devicon.json file as seen here

This PR closes #1988

Link to prove your SVG is correct and up-to-date.

https://angular.dev/press-kit

gabrielfins avatar Dec 04 '23 14:12 gabrielfins

I optimized the plain icons with the tool you sent, but the originals are a bit more complex. They use a freeform gradient, which svg doesn't support (only supports linearGradient and radialGradient), so that's why illustrator rasterizes it. I've been looking into this, but I'm not sure there's any way around it

gabrielfins avatar Dec 05 '23 12:12 gabrielfins

Should be all good now? I removed the data-name as requested and also optimized and uploaded the originals, let me know if anything else needs fixing

gabrielfins avatar Dec 05 '23 14:12 gabrielfins

So when does this get merged?

derBinder avatar Jan 21 '24 19:01 derBinder

So when does this get merged?

@derBinder when it has 1 more accepted review and after the next release: #2105

Snailedlt avatar Jan 22 '24 07:01 Snailedlt

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot :smile:

github-actions[bot] avatar Apr 14 '24 00:04 github-actions[bot]