devicon icon indicating copy to clipboard operation
devicon copied to clipboard

new icon: wolfram (original, original-wordmark, plain, plain-wordmark)

Open Tarang74 opened this issue 1 year ago • 5 comments

Double check these details before you open a PR

  • [x] PR does not match another non-stale PR currently opened
  • [x] PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • [x] PR's base is the develop branch.
  • [x] Your icons are inside a folder as seen here
  • [x] SVG matches the standards laid out here
  • [x] A new object is added in the devicon.json file as seen here

This PR closes NONE

Link to prove your SVG is correct and up-to-date.

https://company.wolfram.com/press-center/

Tarang74 avatar Jul 13 '23 05:07 Tarang74

Includes wolframlanguage icon also

Tarang74 avatar Jul 13 '23 06:07 Tarang74

Everything looks good, but I'm wondering why this is called wolframlanguage instead of wolfram and having wolframlanguage as an altname. Wolfram seems to be the official name, so that is what we should use. If there is no particular reason, please change to wolfram

Wolfram is a company and Wolfram Language is a service from that company, both share the same first name, but since it seems that are no other service that fits on the scope of Devicons I think it's ok to change it to wolfram instead and keep wolframlanguage as an altname. 👍🏼

lunatic-fox avatar Oct 26 '23 17:10 lunatic-fox

@Tarang74 Let us know if you need any help :)

Snailedlt avatar Oct 30 '23 22:10 Snailedlt

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60



Error found regarding filenames:
- Invalid path. This is not a directory: '/home/runner/work/devicon/devicon/icons/wolfram'.

Error checking SVGs: no SVGs to check. Might be caused by above issues.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot :smile:

github-actions[bot] avatar May 06 '24 01:05 github-actions[bot]

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60



Error found regarding filenames:
- Invalid path. This is not a directory: '/home/runner/work/devicon/devicon/icons/wolfram'.

Error checking SVGs: no SVGs to check. Might be caused by above issues.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot :smile:

github-actions[bot] avatar May 06 '24 02:05 github-actions[bot]