devicon icon indicating copy to clipboard operation
devicon copied to clipboard

[BUG] amazonwebservices inconsistent version names

Open risbi0 opened this issue 2 years ago • 2 comments

I have searched through the issues and didn't find my problem.

  • [X] Confirm

Bug description

The versions for amazonwebservices are "plain" and "original-wordmark". No existing equivalent wordmark/non-wordmark types for either versions.

Possible fixes or solutions

I'm still not sure on what should be replaced. It's either: (1) change "plain" to "original", or (2) change "original-wordmark" to "plain-wordmark". Respecting its SVG version, it would be point 1, but basing on other icons (adonisjs, express), it would be point 2.

Additional information

No response

risbi0 avatar Mar 16 '23 04:03 risbi0

Just found the same case for tailwindcss as well.

risbi0 avatar Mar 17 '23 10:03 risbi0

Possible solution

Based on develop icons we should:

  • Rename original-wordmark SVG file to original
  • Rename plain-wordmark SVG file to plain
  • Rename line-wordmark SVG file to line

Then, in devicon.json change the entry as the code below:

    {
        "name": "amazonwebservices",
        "altnames": [
            "aws"
        ],
        "tags": [
            "cloud",
            "hosting",
            "server"
        ],
        "versions": {
            "svg": [
                "original",
                "plain",
                "line"
            ],
            "font": [
                "plain",
                "line"
            ]
        },
        "color": "#f90",
        "aliases": [
            {
                "base": "original",
                "alias": "original-wordmark"
            },
            {
                "base": "plain",
                "alias": "plain-wordmark"
            },
            {
                "base": "line",
                "alias": "line-wordmark"
            }
        ]
    },

I'm not sure if it counts as a change, as long we have aliases to all the possible versions.

lunatic-fox avatar May 02 '23 04:05 lunatic-fox