devicon Bump minimist from 1.2.5 to 1.2.6

Bumps minimist from 1.2.5 to 1.2.6.

Commits

7efb22a 1.2.6
ef88b93 security notice for additional prototype pollution issue
c2b9819 isConstructorOrProto adapted from PR
bc8ecee test from prototype pollution PR
See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@dependabot use these labels will set the current labels as the default for future PRs for this repo and language
@dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
@dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
@dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Sep 16 '22 16:09 dependabot[bot]

@Panquesito7 did you test it locally? Also, did you see the changelog?

Sep 21 '22 16:09 Snailedlt

@Panquesito7 did you test it locally? Also, did you see the changelog?

I haven't tested it locally (we could use Gitpod to deploy the page, though). The changelog or commits seem to be to fix a security issue. https://github.com/devicons/devicon/security/dependabot/6

Sep 21 '22 16:09 Panquesito7

@Panquesito7 did you test it locally? Also, did you see the changelog?

I haven't tested it locally (we could use Gitpod to deploy the page, though). The changelog or commits seem to be to fix a security issue. https://github.com/devicons/devicon/security/dependabot/6

No need to deploy imo. Just a simple build and run would suffice. If it runs, and the code checks are all green, it probably should work.

We could add a build step to the CodeQL workflow though. Maybe just add npm ci, npm build and npm test? Can probably just be added as a replacement of these lines: https://github.com/devicons/devicon/blob/1119b9f84c0290e0f0b38982099a2bd027a48bf1/.github/workflows/codeql-analysis.yml#L45-L55

Sep 22 '22 09:09 Snailedlt

@Panquesito7 did you test it locally? Also, did you see the changelog?

I haven't tested it locally (we could use Gitpod to deploy the page, though). The changelog or commits seem to be to fix a security issue. https://github.com/devicons/devicon/security/dependabot/6

No need to deploy imo. Just a simple build and run would suffice. If it runs, and the code checks are all green, it probably should work.

We could add a build step to the CodeQL workflow though. Maybe just add npm ci, npm build and npm test? Can probably just be added as a replacement of these lines:

https://github.com/devicons/devicon/blob/1119b9f84c0290e0f0b38982099a2bd027a48bf1/.github/workflows/codeql-analysis.yml#L45-L55

Sounds good. Feel free to make a PR for that. 🙂 To make deployment easier and faster, we could also use Gitpod.

Sep 22 '22 14:09 Panquesito7

Having trouble building this locally. The build guide isn't really complete so it's hard to follow. I made an issue to update it: #1414

Oct 02 '22 18:10 Snailedlt

Actually, it seems this PR has been merged previously 🤔 https://github.com/devicons/devicon/pull/1141

Oct 02 '22 19:10 Panquesito7

Hmm, yeah you're right! Did we update the package-lock accidentally somewhere along the way?

Oct 02 '22 20:10 Snailedlt

Hmm, yeah you're right! Did we update the package-lock accidentally somewhere along the way?

Hmm, what do you mean?

Oct 02 '22 20:10 Panquesito7

I mean, how can it change the same thing twice without it having been removed in-between those two PRs?

I'll check the blame later to see if it got reverted or changed recently

Oct 02 '22 20:10 Snailedlt

I mean, how can it change the same thing twice without it having been removed in-between those two PRs?

I'll check the blame later to see if it got reverted or changed recently

That's because it has been merged in develop and there hasn't been any release since March. #1141 was merged in April.

Oct 02 '22 21:10 Panquesito7

Ohhh, so it checks for dependencies in master, and sends a PR in develop? That doesn't seem right. If that's the case, then it's clearly a bug right?

Oct 02 '22 21:10 Snailedlt

Ohhh, so it checks for dependencies in master, and sends a PR in develop? That doesn't seem right. If that's the case, then it's clearly a bug right?

Nope, I changed the branch to develop manually so that it's merged there.

Oct 03 '22 04:10 Panquesito7

Ahh, okey. Makes sense

Oct 03 '22 06:10 Snailedlt

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

Oct 03 '22 20:10 dependabot[bot]