devicon icon indicating copy to clipboard operation
devicon copied to clipboard

new icon: reach (original, plain)

Open RyanKoech opened this issue 3 years ago • 3 comments

Double check these details before you open a PR

  • [X] PR does not match another non-stale PR currently opened
  • [X] PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • [X] PR's base is the develop branch.
  • [X] Your icons are inside a folder as seen here
  • [X] SVG matches the standards laid out here
  • [X] A new object is added in the devicon.json file as seen here

This PR closes NONE

Link to prove your SVG is correct and up-to-date.

https://docs.reach.sh/

RyanKoech avatar Sep 11 '22 12:09 RyanKoech

You need to change your commit name to new icon: reach (original, plain). This is possible by using git commit --amend, then force pushing by using git push -f.

Let us know if you need any help! Thanks. 🙂

__ sema-logo sema-logo Summary: 🛠️ This code needs a fix | Tags: Not maintainable

I believe it's now sorted.

RyanKoech avatar Sep 12 '22 06:09 RyanKoech

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files: Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs: Imgur Images

Here are the icons that will be generated by Icomoon: Imgur Images

Here are the zoomed-in screenshots of the added icons as icons: Imgur Images

Here are the colored versions: Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers, Peek Bot :blush:

github-actions[bot] avatar Sep 13 '22 04:09 github-actions[bot]

Looks great. Thank you! 🚀

__ sema-logo sema-logo Summary: 🏆 This code is awesome | Tags: Elegant, Maintainable

Happy to contribute.

RyanKoech avatar Sep 13 '22 17:09 RyanKoech

Will be merging this PR. If there are any objections, issues, or anything else that has to be done, feel free to make another PR.

Panquesito7 avatar Sep 27 '22 15:09 Panquesito7