devicon
devicon copied to clipboard
new icon: v8 (original)
add icon for google v8 engine
This PR closes #1352
Hi!
I'm the check-bot
and we have some issues with your PR:
Error found in 'devicon.json' for 'v8' entry:
- missing key: 'aliases'.
SVG Error in 'v8-original.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.
Check our CONTRIBUTING guide for more details regarding these errors.
Please address these issues. When you update this PR, I will check your SVGs again.
Thanks for your help, SVG-Checker Bot :smile:
@ngdream could you try and fix the issues found by check-bot above? Altnames is also missing from devicon.json
@ngdream could you try and fix the issues found by check-bot above? Altnames is also missing from devicon.json
thanks
Hi there,
I'm Devicons' Peek Bot and it seems we've ran into a problem.
This path doesn't exist: 'D:\a\devicon\devicon\icons\v8\v8-plain.svg'
Make sure that:
- Your svgs are named and added correctly to the /icons folder as seen here.
- Your icon information has been added to the
devicon.json
as seen here - Your PR title follows the format seen here
I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.
Best of luck, Peek Bot :relaxed:
Hi there,
I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here are the SVGs as intepreted by Icomoon when we upload the files:
Here are the zoomed-in screenshots of the added icons as SVGs:
Here are the icons that will be generated by Icomoon:
Here are the zoomed-in screenshots of the added icons as icons:
Here are the colored versions:
The maintainers will now check for:
- The number of Glyphs matches the number of SVGs that were selected.
- The icons (second group of pictures) look the same as the SVGs (first group of pictures).
- The icons are of high quality (legible, matches the official logo, etc.)
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.
Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.
Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.
Cheers, Peek Bot :blush:
@ngdream the icon doesn't look right when uploaded as a font to icomoon. Are there any icons you could upload that are unicolored?
env.MESSAGE
If you wanna add another icon and another PR, you must create another branch with only the wxwidget
icon changes.
To get further support, feel free to join our Discord community here: https://discord.gg/hScy8KWACQ
@ngdream the icon doesn't look right when uploaded as a font to icomoon. Are there any icons you could upload that are unicolored?
There's still no plain icon as far as I can see
I was attempting to make a plain icon, and noticed the original icon wasn't the same as the official one. So I changed it. Hope you don't mind :)
@kilianpaquier I wasn't able to make a plain version, would you want to give it a try maybe?
Original version can be found here: https://v8.dev/logo For the resized and optimized version, please take a look at my latest commit to this PR
I was attempting to make a plain icon, and noticed the original icon wasn't the same as the official one. So I changed it. Hope you don't mind :)
@kilianpaquier I wasn't able to make a plain version, would you want to give it a try maybe?
Original version can be found here: https://v8.dev/logo For the resized and optimized version, please take a look at my latest commit to this PR
Hello @Snailedlt, here's a possibility for the v8 plain logo :
I was attempting to make a plain icon, and noticed the original icon wasn't the same as the official one. So I changed it. Hope you don't mind :) @kilianpaquier I wasn't able to make a plain version, would you want to give it a try maybe? Original version can be found here: https://v8.dev/logo For the resized and optimized version, please take a look at my latest commit to this PR
Hello @Snailedlt, here's a possibility for the v8 plain logo :
i love it guys! i love you @kilianpaquier
i think is good
let's merge now :cry:
Hi there,
I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here are the SVGs as intepreted by Icomoon when we upload the files:
Here are the zoomed-in screenshots of the added icons as SVGs:
Here are the icons that will be generated by Icomoon:
Here are the zoomed-in screenshots of the added icons as icons:
Here are the colored versions:
The maintainers will now check for:
- The number of Glyphs matches the number of SVGs that were selected.
- The icons (second group of pictures) look the same as the SVGs (first group of pictures).
- The icons are of high quality (legible, matches the official logo, etc.)
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.
Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.
Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.
Cheers, Peek Bot :blush:
Hi there,
I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here are the SVGs as intepreted by Icomoon when we upload the files:
Here are the zoomed-in screenshots of the added icons as SVGs:
Here are the icons that will be generated by Icomoon:
Here are the zoomed-in screenshots of the added icons as icons:
Here are the colored versions:
The maintainers will now check for:
- The number of Glyphs matches the number of SVGs that were selected.
- The icons (second group of pictures) look the same as the SVGs (first group of pictures).
- The icons are of high quality (legible, matches the official logo, etc.)
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.
Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.
Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.
Cheers, Peek Bot :blush:
@Panquesito7 This is ready for merging now if you agree. Your review is currently blocking the merge