devicon
devicon copied to clipboard
new icon: matplotlib (original, original-wordmark, plain, plain-wordmark)
Double check these details before you open a PR
- [x] PR does not match another non-stale PR currently opened
- [x] PR name matches the format new icon: Icon name (versions separated by comma). More details here
- [x] PR's base is the
develop
branch. - [x] Your icons are inside a folder as seen here
- [x] SVG matches the standards laid out here
- [x] A new object is added in the
devicon.json
file as seen here
This PR closes #859
Link to prove your SVG is correct and up-to-date.
https://github.com/matplotlib/matplotlib
Hi!
I'm the check-bot
and we have some issues with your PR:
SVG Error in 'matplotlib-original.svg':
- SVG contains `stroke` property. This will get ignored by Icomoon. Please convert them to fills.
SVG Error in 'matplotlib-original-wordmark.svg':
- SVG contains `stroke` property. This will get ignored by Icomoon. Please convert them to fills.
SVG Error in 'matplotlib-plain.svg':
- SVG contains `stroke` property. This will get ignored by Icomoon. Please convert them to fills.
SVG Error in 'matplotlib-plain-wordmark.svg':
- SVG contains `stroke` property. This will get ignored by Icomoon. Please convert them to fills.
Check our CONTRIBUTING guide for more details regarding these errors.
Please address these issues. When you update this PR, I will check your SVGs again.
Thanks for your help, SVG-Checker Bot :smile:
Hi!
I'm the check-bot
and we have some issues with your PR:
SVG Error in 'matplotlib-original.svg':
- SVG contains `stroke` property. This will get ignored by Icomoon. Please convert them to fills.
SVG Error in 'matplotlib-original-wordmark.svg':
- SVG contains `stroke` property. This will get ignored by Icomoon. Please convert them to fills.
Check our CONTRIBUTING guide for more details regarding these errors.
Please address these issues. When you update this PR, I will check your SVGs again.
Thanks for your help, SVG-Checker Bot :smile:
@Panquesito7 Since the original
icons won't be used in icomoon can you skip the error ?
Because converting the dotted stroke will increase a lot the SVG files for no benefices.
@Panquesito7 Like I said in my previous message:
Since the
original
icons won't be used in icomoon can you skip / ignore the error ? Because converting the dotted stroke will increase a lot the SVG files for no benefices.
@Panquesito7 Since the
original
icons won't be used in icomoon can you skip the error ? Because converting the dotted stroke will increase a lot the SVG files for no benefices.
Hey! Not sure if we can actually skip that error. I think we should still follow these rules. @Snailedlt, what do you think we should do here?
This test exists because icomoon can't handle strokes but these two original
icons won't be used by icomoon.
The check (Bot) should ignore the original
versions if plain
versions exists.
@Panquesito7 I think what @BenSouchet is saying makes sense, but I'm a bit afraid to vouch for it since I don't know the intricacies.
We can try with peek:bot, if it still looks okey after that imo, we can merge. Then we'll just keep an eye out for that icon, and revert if it causes any issues :)
The paths for plain versions should be merged into one, other than that it looks good :)
Okay, I optimized the paths :)
Hi!
I'm the check-bot
and we have some issues with your PR:
SVG Error in 'matplotlib-original.svg':
- SVG contains `stroke` property. This will get ignored by Icomoon. Please convert them to fills.
SVG Error in 'matplotlib-original-wordmark.svg':
- SVG contains `stroke` property. This will get ignored by Icomoon. Please convert them to fills.
Check our CONTRIBUTING guide for more details regarding these errors.
Please address these issues. When you update this PR, I will check your SVGs again.
Thanks for your help, SVG-Checker Bot :smile:
Hi there,
I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here are the SVGs as intepreted by Icomoon when we upload the files:
Here are the zoomed-in screenshots of the added icons as SVGs:
Here are the icons that will be generated by Icomoon:
Here are the zoomed-in screenshots of the added icons as icons:
Here are the colored versions:
The maintainers will now check for:
- The number of Glyphs matches the number of SVGs that were selected.
- The icons (second group of pictures) look the same as the SVGs (first group of pictures).
- The icons are of high quality (legible, matches the official logo, etc.)
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.
Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.
Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.
Cheers, Peek Bot :blush: