devicon icon indicating copy to clipboard operation
devicon copied to clipboard

new icon: hibernate (original, original-wordmark, plain, plain-wordmark)

Open kilianpaquier opened this issue 2 years ago • 5 comments

Double check these details before you open a PR

  • [x] PR does not match another non-stale PR currently opened
  • [x] PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • [x] PR's base is the develop branch.
  • [x] Your icons are inside a folder as seen here
  • [x] SVG matches the standards laid out here
  • [x] A new object is added in the devicon.json file as seen here

This PR closes NONE

Link to prove your SVG is correct and up-to-date.

https://hibernate.org/

kilianpaquier avatar Jun 23 '22 20:06 kilianpaquier

https://www.jmdoudoux.fr/java/dej/chap-hibernate.htm https://www.tutorialspoint.com/hibernate/orm_overview.htm https://en.wikipedia.org/wiki/Hibernate_(framework)

The only difference between nhibernate and hibernate is the target language.

kilianpaquier avatar Jul 17 '22 15:07 kilianpaquier

@kilian-paquier The wikipedia link you sent calls it Hibernate ORM.

Okey, so hibernate is the company/organization name, and hibernate ORM is the product name. But then the product is also called hibernate (quite confusing if you ask me).

So then, shouldn't the name be hibernateorm? We can have hibernate as an alt name too

Snailedlt avatar Jul 17 '22 21:07 Snailedlt

Hibernate is a framework, it seems to be owned by Red Hat, but it's open source. Hibernate provides functionalities/libraries/tools, such as the hibernate ORM, validator, etc.

All the functionalities come with the same logo.

Here's the GitHub link of hibernate : https://github.com/hibernate

kilianpaquier avatar Jul 18 '22 06:07 kilianpaquier

Yeah, looking at their twitter account it says something like "...hibernate is a suite of open-source projects..."

@Panquesito7 Looks like this is a suite of products (not a single one), do you think it qualifies for devicons?

Snailedlt avatar Jul 18 '22 11:07 Snailedlt

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files: Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs: Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon: Imgur Images

Here are the zoomed-in screenshots of the added icons as icons: Imgur Images Imgur Images

Here are the colored versions: Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers, Peek Bot :blush:

github-actions[bot] avatar Aug 06 '22 10:08 github-actions[bot]