devicon icon indicating copy to clipboard operation
devicon copied to clipboard

[FEATURE REQUEST] Differentiate vertical and horizontal icons

Open Snailedlt opened this issue 3 years ago • 0 comments

I have searched through the issues and didn't find my problem.

  • [X] Confirm

Problem

A lot of logos/icons nowadays have both vertical and horizontal icons. It would be nice if we could account for this, and add both for icons wherever possible, so that we don't have make a decision on which one to add. Since some companies has TOS for their icons, you might be breaking their TOS by using the wrong icon orientation. Giving the option to choose orientation would thus make it easier for our users to uphold the TOS.

An example of an icon that has both vertical and horizontal versions: #921

Possible Solution

Ideas for a solution

For this to work we'd need to add more fields to the devicon.json file. Specifically we would need to add a vertical and horizontal version for each icon type.

Currently we have these types of icons:

{iconname}-original.svg
{iconname}-plain.svg
{iconname}-line.svg
{iconname}-original-wordmark.svg
{iconname}-plain-wordmark.svg
{iconname}-line-wordmark.svg

With the change where we distinguish vertical and horizontal icons, we would end up with the following types of icons:

{iconname}-vertical-original.svg
{iconname}-vertical-plain.svg
{iconname}-vertical-line.svg
{iconname}-vertical-original-wordmark.svg
{iconname}-vertical-plain-wordmark.svg
{iconname}-vertical-line-wordmark.svg

{iconname}-horizontal-original.svg
{iconname}-horizontal-plain.svg
{iconname}-horizontal-line.svg
{iconname}-horizontal-original-wordmark.svg
{iconname}-horizontal-plain-wordmark.svg
{iconname}-horizontal-line-wordmark.svg

Benefits

  1. Make it possible for our users to adhere to TOS for some icons, that require either vertical or horizontal icons based on the icon sizes.
  2. Larger assortment of icons to fit more situations.
  3. No longer any need to wonder/discuss whether we should add the vertical or horizontal version. Now we can just add both.

Downsides

  1. A bit of groundwork is needed, especially if we need to account for backwards compatibility.
  2. Potentially a bit more complex contribution process (though less decisionmaking due to benefit # 3).

Additional information

One of the issues I can see with the approach above is backwards compatability. We would have to translate from the old solution to the new, in a way such that users still get the same icons they did before, but also so that new contributors don't have to account for backwards compatibility.

Snailedlt avatar Jun 08 '22 14:06 Snailedlt