btleplug icon indicating copy to clipboard operation
btleplug copied to clipboard

Published 20 hours ago • verified publisher icon deviceplug

fix CBManager crash on macOS `<10.15`

Open oletf opened this issue 1 year ago • 5 comments

my current fix for #335

oletf avatar Sep 07 '23 12:09 oletf

actually wondering how format got a fail on a file which is not part of the commit :D

oletf avatar Sep 12 '23 09:09 oletf

I'm really bad about updating formatting, so it tends to file through. I need to update our CI to warn, not fail, on formatting.

Don't worry about it, I'll try to get the patch in and formatting updated soon.

qdot avatar Sep 12 '23 16:09 qdot

Ok, looking at this again...

The one problem I see here is that we aren't actually checking the OS platform we're looking at the version of, so this check will run on both macOS and iOS (I build this library into an iOS application). Do we need to do extra target checks here for knowing if we're running on macOS and iOS? Mainly want to make sure before I merge this, as debugging this on iOS is a pain if anything goes wrong.

qdot avatar Sep 16 '23 19:09 qdot

yeah I thought about this but forgot to post a thing about it ! should I change the match to cover both ios edge-cases too then ?

oletf avatar Sep 18 '23 08:09 oletf

@qdot I don't have any iOS device to try it on, would it be possible for you to get what a dbg!(os_info::get()) does print on your iOS device ? I'm not sure of what I'd need to match for to check for iOS vs macOS from os_info crate doc... Thanks forward

oletf avatar Sep 25 '23 12:09 oletf