wpgtk icon indicating copy to clipboard operation
wpgtk copied to clipboard

wallust backend

Open MyGitHubBlueberry opened this issue 1 year ago • 17 comments

Please, add wallust as a backend. (If settings will be possible)

MyGitHubBlueberry avatar May 18 '24 15:05 MyGitHubBlueberry

Second :)

vaskark avatar May 22 '24 19:05 vaskark

Third! ;P

CianJDuggan avatar Jul 10 '24 20:07 CianJDuggan

Fourth ;P

sfzaw avatar Aug 12 '24 19:08 sfzaw

Fifth!

ekollof avatar Aug 13 '24 09:08 ekollof

I'll look into this

deviantfero avatar Oct 21 '24 00:10 deviantfero

would a simple script be enough to replace wal ? I don't fit this use case, so suggestions are welcome

explosion-mental avatar Feb 22 '25 22:02 explosion-mental

Heard, I'm debating whether or not to fork pywal to be able to implement these feature requests

On Sun, Feb 23, 2025, 6:35 AM explosion-mental @.***> wrote:

would a simple script https://explosion-mental.codeberg.page/wallust/pywal_replacement.html be enough to replace wal ? I don't fit this use case, so suggestions are welcome

— Reply to this email directly, view it on GitHub https://github.com/deviantfero/wpgtk/issues/303#issuecomment-2676432049, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACVCGSJFHR7JO2RYDJEVRAT2RD3THAVCNFSM6AAAAABH5Q5ZFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZWGQZTEMBUHE . You are receiving this because you commented.Message ID: @.***> [image: explosion-mental]explosion-mental left a comment (deviantfero/wpgtk#303) https://github.com/deviantfero/wpgtk/issues/303#issuecomment-2676432049

would a simple script https://explosion-mental.codeberg.page/wallust/pywal_replacement.html be enough to replace wal ? I don't fit this use case, so suggestions are welcome

— Reply to this email directly, view it on GitHub https://github.com/deviantfero/wpgtk/issues/303#issuecomment-2676432049, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACVCGSJFHR7JO2RYDJEVRAT2RD3THAVCNFSM6AAAAABH5Q5ZFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZWGQZTEMBUHE . You are receiving this because you commented.Message ID: @.***>

deviantfero avatar Feb 24 '25 04:02 deviantfero

Heard, I'm debating whether or not to fork pywal to be able to implement these feature requests

How would forking pywal help?

I've implemented the wallust pywal subcommand to have 'compatibility' with other tools that use pywal, like wpgtk. This is mostly, there are many other tools (you can consider even scripts) that have hardcoded pywal into it. Since there is even a pywal16 fork, I think it is a good idea if you plan on switching in between without breaking anything.

explosion-mental avatar Mar 22 '25 23:03 explosion-mental

I think going forward I would like more control over that, including being able to add color generating backends like wallust.

wpgtk leverages pywal's API, it does not necessarily adhere to the vanilla use of pywal in many ways, so to me it makes sense to want to keep control over it too.

It will probably not happen though, I will keep pestering @eylles in the meantime if any bugs rise up in pywal16 for wpgtk's use-case.

deviantfero avatar Mar 27 '25 02:03 deviantfero

well, if you wanted a wallust to wpgtk layer then that would require @explosion-mental to expose some of the internal API of wallust in such a way that it can be called from python scripts and then if you want wallust as a replacement without touching any of the wpgtk api then simply have shim python module to wrap the internal calls from wallust with the pywal names.

eylles avatar Mar 27 '25 02:03 eylles

my point is that you could add wallust as a pywal backend with no need for a python shim module, in a way pywal would be the python shim we're talking about, you can call wallust (be it from the CLI or whatever) from inside a colorscheme/wallust.py module that just implements the gen_color, adjust and get functions, we just need to get the array of colors after all.

then in wpgtk wallust would simply be listed as one of the backends that pywal can generate a colorscheme with.

honestly I think I can do a PR against your repository instead @eylles.

deviantfero avatar Mar 27 '25 02:03 deviantfero

I played around with wallust, pretty cool colorschemes! and it seems to be a replacement for pywal, which is cool, I would like to integrate it into wpgtk and pywal16 though as to make it easier to edit colorschemes in wpgtk.

@explosion-mental is there a possibility you could implement a script or flag that simply makes wallust output a list of the colorscheme, something like:

$ wallust colors [path/to/image]
#color0 #color1 #color2 ... #color15 

then we could integrate it into pywal16 like I was saying in my previous comment, and it could also be useful for other people to kinda connect wallust to other programs via standard output.

deviantfero avatar Mar 27 '25 02:03 deviantfero

my point is that you could add wallust as a pywal backend with no need for a python shim module, in a way pywal would be the python shim we're talking about, you can call wallust (be it from the CLI or whatever) from inside a colorscheme/wallust.py module that just implements the gen_color, adjust and get functions, we just need to get the array of colors after all.

then in wpgtk wallust would simply be listed as one of the backends that pywal can generate a colorscheme with.

yeh, that may be the path of least resistance, @explosion-mental if you can get wallust to ouput just the colors in hex in a manner similar to how schemer2 does (plain text separated by newline) and i can add wallust as a backend today

Image

eylles avatar Mar 27 '25 02:03 eylles

so small update, we now have a feature request open to wallust, it all now depends on the time and willingness @explosion-mental may have on fullfilling the feature request, i do not know rust so i can't do that myself tho.

https://codeberg.org/explosion-mental/wallust/issues/185

eylles avatar Oct 14 '25 15:10 eylles